Converter yolo OBB to labelstudio. Which branche to make PR?

[cfrancois7]

When following the step from tutorial, the import does not take account the YOLO OBB data.
The converter only works for YOLO data but not YOLO OBB.

I do not understand how to import properly the data into Label Studio when my data are YOLO OBB format?

[cfrancois7]

I made the code and tested it.
It works fine.

See the branch
It works like :

python main.py import yolo_obb -i path_to_my_data -o path_to_my_output/output.json --image-root-url "/data/local-files/?d=my_datasets/images"
I did not add test function. It is in the agenda.

However, on which branch should I make the PR?
I did not see a develop branch.

[makseq]

Hello, sorry for the late response.

1. If you want to contribute, you have to create a new PR:
   

2. Your code should be covered with a test, as example you can check this:
   https://github.com/cfrancois7/label-studio-sdk/blob/feat/import_yolo_obb/tests/custom/converter/test_import_yolo.py

3. I see you've created a separate Python file for YOLO OBB. However, I would keep everything in the same file: imports/yolo.py. I suggest splitting convert_yolo_obb_to_ls into a few smaller atomic subfunctions and making YOLO and YOLO OBB optional parts of them. Your current implementation requires maintaining two very similar files - yolo.py and yolo_obb.py - and it's complicated.