400/add managing agency filter type to capital projects #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TangoYankee
reviewed
Jan 24, 2025
| }: { | ||
| boroughId: string; | ||
| communityDistrictId: string; | ||
| limit: number; | ||
| offset: number; | ||
| managingAgency: string; |
There was a problem hiding this comment.
You're already checking for truthiness underneath, so the code itself is good. But for type housekeeping, I think managingAgency could also be undefined because it's optional
I see in the service that we're setting "managingAgency" to a default value of an "empty string" and then doing a truthy check in the sql query. Truthy checks are considered a "gotcha". They don't always behave predictably. Instead, if we're going to give it a default value, it should be null. Then, we explicitly check for null values.
Suggested change
| managingAgency: string; | |
| managingAgency: string | null; |
TangoYankee
reviewed
Jan 24, 2025
| @@ -129,6 +131,9 @@ export class BoroughRepository { | |||
| and( | |||
| eq(communityDistrict.boroughId, boroughId), | |||
| eq(communityDistrict.id, communityDistrictId), | |||
| managingAgency | |||
There was a problem hiding this comment.
Suggested change
| managingAgency | |
| managingAgency !== null |
TangoYankee
reviewed
Jan 24, 2025
| @@ -71,8 +72,9 @@ export class BoroughService { | |||
| communityDistrictId, | |||
| limit = 20, | |||
| offset = 0, | |||
| managingAgency = "", | |||
There was a problem hiding this comment.
Suggested change
| managingAgency = "", | |
| managingAgency = null, |
TangoYankee
reviewed
Jan 24, 2025
| @@ -74,6 +74,7 @@ export class CityCouncilDistrictService { | |||
| async findCapitalProjectsById({ | |||
| limit = 20, | |||
| offset = 0, | |||
| managingAgency = "", | |||
There was a problem hiding this comment.
Same "null" feedback as community districts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #400
I found some inconsistencies in how we write CD and CCD so I fixed those in here as well (specifying a return type in the service, and adding limit and offset query params to the borough mocks)