Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Multiple Plugins Per Assembly #8

Open
Foxtrek64 opened this issue Oct 27, 2024 · 0 comments
Open

Allow Multiple Plugins Per Assembly #8

Foxtrek64 opened this issue Oct 27, 2024 · 0 comments

Comments

@Foxtrek64
Copy link
Contributor

Currently, only one plugin is allowed per library. This matches the typical use case. However, there are use cases where multiple plugins per assembly is appropriate.

This corresponds with #7 wherein a plugin will be conditionally loaded based on a set of criteria.

There are two ways to do this:

  1. Just allow multiple plugins per assembly overall - if the assembly has multiple, add all (that match the predicate) to the plugin tree. This may require some more organization.
  2. Get a list of all plugins in the assembly, apply the filter, then assert that there is only a single plugin or else fail to load that assembly.

For the first impl, I would like to propose the 2nd option, but we can come back later and make it the first if need be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant