Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment Lightformers are not working #581

Open
5 tasks done
alvarosabu opened this issue Jan 7, 2025 · 2 comments · May be fixed by #584
Open
5 tasks done

Environment Lightformers are not working #581

alvarosabu opened this issue Jan 7, 2025 · 2 comments · May be fixed by #584
Assignees
Labels
bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority)

Comments

@alvarosabu
Copy link
Member

Describe the bug

Adding a light former should create the object inside the envMap

<Environment background preset="sunset" :blur="1" :frames="Infinity">
    <Lightformer
      :intensity="1"
      form="ring"
      color="red"
      :position="[-15, 4, -18]"
      :scale="10"
      :target="[0,0,0]"
    />
</Environment>

Reproduction

https://stackblitz.com/~/edit/tresjs-environment-lightworkers?file=src/App.vue

Steps to reproduce

No response

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (4) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 18.20.3 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.3 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm
  npmPackages:
    @tresjs/cientos: 4.0.3 => 4.0.3 
    @tresjs/core: 4.3.1 => 4.3.1 
    @tresjs/leches: ^0.14.0 => 0.14.0 
    vite: ^6.0.3 => 6.0.5

Used Package Manager

pnpm

Code of Conduct

@alvarosabu alvarosabu self-assigned this Jan 7, 2025
@alvarosabu alvarosabu added bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority) labels Jan 7, 2025
@alvarosabu
Copy link
Member Author

@hawk86104 I think you contributed to this feature. Do you know what could be wrong?

@hawk86104
Copy link
Contributor

@hawk86104 I think you contributed to this feature. Do you know what could be wrong?

I tried it, and indeed, using import { Environment, Lightformer } from '@tresjs/cientos' results in an issue where Lightformer cannot be imported. It might be because cientos has been continuously updating the Environment. In some of my own projects, I’ve already been using a modified Environment component, so I haven’t encountered this problem. I’ll compare the code later and submit a PR to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p4-important-bug Violate documented behavior or significantly improve performance (priority)
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants