Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(why) Does a Repository's language have to be serde_json::Value? #744

Open
Stef16Robbe opened this issue Dec 24, 2024 · 1 comment
Open

Comments

@Stef16Robbe
Copy link

First of all, thanks for making this crate! So far it's been great to use.

I just had a small nitpick/question, when retrieving a repository, the primary language has a type of serde_json::Value: https://github.com/XAMPPRocky/octocrab/blob/main/src/models.rs#L751.

I'm questioning whether this is really necessary. I'm listing the starred repo's by the current user and the example response in the GitHub API docs mention that this value can be null or a string:

"language": {
  "type": [
    "string",
    "null"
  ]
},

I also saw that this was not changed since the start of the project (5c1ba26), so maybe this can be revisited? What do you think?

@XAMPPRocky
Copy link
Owner

Thank you for your issue! This can probably be revisited/changed. I don't remember why it is that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants