You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm questioning whether this is really necessary. I'm listing the starred repo's by the current user and the example response in the GitHub API docs mention that this value can be null or a string:
"language": {
"type": [
"string",
"null"
]
},
I also saw that this was not changed since the start of the project (5c1ba26), so maybe this can be revisited? What do you think?
The text was updated successfully, but these errors were encountered:
First of all, thanks for making this crate! So far it's been great to use.
I just had a small nitpick/question, when retrieving a repository, the primary language has a type of
serde_json::Value
: https://github.com/XAMPPRocky/octocrab/blob/main/src/models.rs#L751.I'm questioning whether this is really necessary. I'm listing the starred repo's by the current user and the example response in the GitHub API docs mention that this value can be
null
or astring
:I also saw that this was not changed since the start of the project (5c1ba26), so maybe this can be revisited? What do you think?
The text was updated successfully, but these errors were encountered: