Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move runtime to be inside the toolchain #299

Open
jhance opened this issue Dec 20, 2024 · 1 comment
Open

Move runtime to be inside the toolchain #299

jhance opened this issue Dec 20, 2024 · 1 comment

Comments

@jhance
Copy link

jhance commented Dec 20, 2024

I am trying to use rules_cuda with a hermetic toolchain (e.g. my cuda stuff is not from the system but from some external workspace, whose BUILD file I am currently writing manually based on the prior art in this repo). Among other issues which are so far easily locally patched out I am wondering why the runtime is a flag instead of part of the toolchain. I think static/dynamic should be a target setting and let toolchain selection decide whether we are using the dynamic or static runtime. Then pass --@rules_cuda//:runtime_static or something to switch to static. (This means we would register 2 toolchains instead of 1).

Without this it is a pain to support multiple toolchains / cuda versions because selecting the cuda version will also always require passing a secondary flag to pick a runtime for it.

@cloudhan
Copy link
Collaborator

The flag is simply inherited from tensorflow tfruntime toolchain, you can access it from the orphan branch https://github.com/bazel-contrib/rules_cuda/tree/subtree-tfruntime. The main branch is a rewrote version with native starlark implementation.

As for hermetic toolchain, you should watch #283

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants