-
Notifications
You must be signed in to change notification settings - Fork 20
Use one @import per folder? #102
Comments
I would be hesitant to do this. I tried it with my current implementation of Scally, and as you should only be including the utilities, objects, components that you actually need for a given project, it can become confusing to find what you are looking for especially when you add generated breakpoints and other variable declarations into the mix. My personal experience has been that it is easiest to control from the master I would also argue that it may be too opinionated to make this call, and users of the framework could choose how they want to organize this file. I am not sure it makes sense to commit the master |
Yeah, after I posted it I thought it wasn't such a great idea, since because Scally is highly customisable, you get in to that pain point of removing imported files and having trailing commas break your build - just like when you do the one line
Great call, @kllevin. It's not included as a bower or npm install, so it shouldn't be in the repo. Currently its a pain because you have to customise +1 for removing it |
I'm thinking we can write a test to check sass compilation, linting, etc. without actually having to check in `style.scss'. Hoping to make it part of the CI/Build process for Scally as well. |
+1 for removing |
I like this idea of @hugogiraudel's to have one @import per folder with comma separated files http://sass-guidelin.es/#main-file (scroll down a bit)
The text was updated successfully, but these errors were encountered: