Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return error on verification functions #29

Open
fedekunze opened this issue May 8, 2020 · 1 comment
Open

return error on verification functions #29

fedekunze opened this issue May 8, 2020 · 1 comment
Labels
enhancement New feature or request go Issues pertaining to the Go implementation

Comments

@fedekunze
Copy link

On the SDK implementation, we updated ICS23 to return an error when the verification failed. Would it be possible to do the same here now that we doing the migration?

cc: @cwgoes @AdityaSripal

https://github.com/confio/ics23/blob/9f53dd0c42123f18211f8671500d257696fd32e0/go/ics23.go#L36

https://github.com/confio/ics23/blob/9f53dd0c42123f18211f8671500d257696fd32e0/go/ics23.go#L52

@crodriguezvega crodriguezvega added enhancement New feature or request go Issues pertaining to the Go implementation labels Jan 18, 2024
@colin-axner
Copy link
Contributor

colin-axner commented Oct 22, 2024

It turns out, without needing to support compressed or batch proofs, we can use the proof.Verify(...) function directly. I've updated that in ibc-go here. We are choosing not to change the VerifyMembership and VerifyNonMembership functions to avoid unnecessary disruption (as it is a breaking change)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request go Issues pertaining to the Go implementation
Projects
None yet
Development

No branches or pull requests

3 participants