Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update appsec deployment to work with tls #222

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

update appsec deployment to work with tls #222

wants to merge 3 commits into from

Conversation

mmetc
Copy link
Contributor

@mmetc mmetc commented Jan 7, 2025

No description provided.

@mmetc mmetc changed the title fix https://github.com/crowdsecurity/helm-charts/issues/217 fix for appsec + tls Jan 7, 2025
@github-actions github-actions bot added the needs/kind Kind label required label Jan 7, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

@mmetc: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the forked project rr404/oss-governance-bot repository.

@mmetc mmetc requested a review from he2ss January 7, 2025 14:38
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025

@mmetc: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the forked project rr404/oss-governance-bot repository.

@mmetc mmetc changed the title fix for appsec + tls update appsec deployment to work with tls Jan 7, 2025
@mmetc mmetc added the kind/fix fixing a bug label Jan 7, 2025
@github-actions github-actions bot removed the needs/kind Kind label required label Jan 7, 2025
@mmetc mmetc marked this pull request as draft January 8, 2025 15:15
he2ss
he2ss reviewed Jan 8, 2025
View reviewed changes
charts/crowdsec/templates/appsec-deployment.yaml Outdated Show resolved Hide resolved
charts/crowdsec/templates/appsec-deployment.yaml Outdated Show resolved Hide resolved
charts/crowdsec/templates/appsec-deployment.yaml Outdated Show resolved Hide resolved
charts/crowdsec/templates/appsec-deployment.yaml Outdated Show resolved Hide resolved
charts/crowdsec/templates/appsec-deployment.yaml Outdated Show resolved Hide resolved
charts/crowdsec/templates/appsec-deployment.yaml Outdated Show resolved Hide resolved
@mmetc mmetc force-pushed the appsec-tls branch 3 times, most recently from c2b518f to 5c8ee4c Compare January 9, 2025 11:03
@mmetc mmetc marked this pull request as ready for review January 9, 2025 11:21
@mmetc mmetc requested a review from he2ss January 9, 2025 11:22
@mmetc mmetc marked this pull request as draft January 9, 2025 11:24
@mmetc mmetc marked this pull request as ready for review January 9, 2025 11:31
@mmetc
Copy link
Contributor Author

mmetc commented Jan 9, 2025

updated and tested again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@he2ss he2ss Awaiting requested review from he2ss

Assignees
No one assigned
Labels
kind/fix fixing a bug needs/area
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmetc @he2ss