Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specific exception type when encountering unsupported versions of input files #2676

Open
maxnoe opened this issue Jan 9, 2025 · 0 comments

Comments

@maxnoe
Copy link
Member

maxnoe commented Jan 9, 2025

Please describe the use case that requires this feature.

When encountering unsupported (not yet or old, dropped versions) we raise inconsistent, generic python errors.

ValueError for the optics table, OSError else (I think it used to be the more fitting IOError but was changed in an automatic refactoring.

Describe the solution you'd like

We should use a specific exception in this case that is a ctapipe exception type for this explicit purpose.

Additional context

LST chain wants to add back explicit support for older files, which would be better handled with a specific exception type.
cta-observatory/cta-lstchain#1329 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant