CMakeLists doesn't build a library

[oedze]

The CMakeLists is now used to create a few executables with different settings.

It can't however be used as a static library right now which is usefull for embedded devices.

being able to do

add_subdirectory(path/to/nanoMODBUS)

add_executable(myproject main.c)

target_link_libaries(myproject PRIVATE nanomodbus)

in our main projects CMakeLists.txt would be ideal for our scenario.

To be able to do this requires some change to the current CMakeLists.txt. If anyone's interested i can make a pull request.
If i do this i would also prefer to move the nanomodbus.h to a include folder.

[debevv]

Hi, the CMakeLists in the repo was never meant to be used by the user, really is there just to build the various test/examples that were useful to me during development.
The "official" way to use nanomodbus is to copy the .c and .h in your codebase and compile everything together.

[donghoonpark]

How about supporting both approaches?
Adding nanomodbus as a library in CMake and compiling test examples with the library link would be the easiest way to achieve this.
Furthermore, for the project's CI, adopting a unit testing framework is also worth considering. If you don’t have time to implement it, I’d be happy to create a PR for it. Is there any particular reason you don’t want to make it a CMake-integrable library?

[debevv]

No reason really, I just think that dropping the sources in the codebase is the simplest option. Anyway, if you find it useful, I will add a couple of lines in the CMakeLists to build a library.
Regarding the tests, what do you mean with a unit testing framework?

[debevv]

Added library target in a1705c0

[donghoonpark]

I really appreciate your quick feedback.
Library definition is quite useful when I use library with internet loading cmake command such as FetchContent.
Regarding the unittest framework, to build test cases with minimal code and integrate them easily into the development environment, frameworks such as GoogleTest or Catch2 are commonly used, as they offer efficiency and compatibility.

[oedze]

Great! I can't test it right now, but if i include the subdirectory using add_subdirectory call, it will also create all the extra libraries right?
to allow the use of the header files in the libraries the target_include_directories(nanomodbus PUBLIC .) can be added

or even better (in my opionin) move the nanomodbus.h file to a folder called include/nanomodbus/ If you then do target_include_directories(nanomodbus PUBLIC include) you can always include #include "nanomodbus/nanomodbus.h" in your c/c++ file

[donghoonpark]

nanomodbus have no extra library. If you call add_subdirectory, it gives you nanomodbus library suite. I already made a PR #79 that includes header file in library suite as well. Until the PR merge into master, you can refer the example HERE.