Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoplay of TV queu is enabled regardless of config #192

Open
Thomahawkuru opened this issue Sep 18, 2024 · 5 comments
Open

Autoplay of TV queu is enabled regardless of config #192

Thomahawkuru opened this issue Sep 18, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@Thomahawkuru
Copy link

Before we begin, i am aware of #82 and #190. But somehow autoplay is always enabled regardless of the config on 2.1.0.

To Reproduce
Steps to reproduce the behavior:

  1. Disable autoplay in both Android youtube APP and cast device youtube APP settings
  2. Connect phone to cast device and play a video.
  3. Disable 'autoplay' toggle in TV queu on phone.
  4. Run iSponsorblockTV config main_tui.py
  5. Connect to cast devices using the manual link code method, and disable autoplay config setting.
  6. Save config and run iSponsorblockTV main.py
  7. Observe TV queu autoplay toggle being turned on automatically (and unable to toggle off while iSponsorblockTV is running)
  8. Video's are autoplayed on the castdevice.

Expected behavior
TV queu autoplay behavior following autoplay setting of the config.

iSponsorBlockTV server (please complete the following information):

  • Version: 2.1.0
  • OS: Linux
  • Python version: 3.8.10
  • Cast Devices: Hisense Vidaa OS, Chromecast V2
@Thomahawkuru Thomahawkuru added the bug Something isn't working label Sep 18, 2024
@dmunozv04
Copy link
Owner

Please post your config (making sure to redact sensitive info). Also, calling main_tui.py sets the data_dir to a different place that what the regular program does; try opening the configurator by using main.py --setup

@Thomahawkuru
Copy link
Author

Thanks for getting back quickly. Can confirm that running main.py --setup, the autoplay config is applied correctly. So seems like i was wrong in using main_tui.py to set config for main.py? Are these unrelated?

main_tui.py puts the config in home/data/config.json/config.json:

{
"devices": [
{
"screen_id": "{redacted}",
"name": "Platte TV",
"offset": 0
},
{
"screen_id": "{redacted}",
"name": "TV kast",
"offset": 0
}
],
"apikey": "{redacted}",
"skip_categories": [
"sponsor",
"selfpromo"
],
"channel_whitelist": [],
"skip_count_tracking": true,
"mute_ads": false,
"skip_ads": false,
"auto_play": false
}

However cant find where main.py --config puts the config.json.

@dmunozv04
Copy link
Owner

dmunozv04 commented Sep 18, 2024

@Thomahawkuru You're welcome. main_tui.py was used for testing and should probably be removed, and it just forces the config dir to data. The main script will save your config.json on user_data_dir("iSponsorBlockTV", "dmunozv04") from appdirs. Maybe another command to view the data_dir path could be useful

@Thomahawkuru
Copy link
Author

Thank you for clarifying, sorry for my confusion.

@dmunozv04
Copy link
Owner

Don't worry, this gives me the opportunity to make it better and more clear in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants