Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AddRateLimiter could have better explanation of QueueLimit #34442

Open
toddlucas opened this issue Jan 7, 2025 · 1 comment
Open

AddRateLimiter could have better explanation of QueueLimit #34442

toddlucas opened this issue Jan 7, 2025 · 1 comment
Assignees
Labels
aspnet-core/svc performance/subsvc seQUESTered Identifies that an issue has been imported into Quest. Source - Docs.ms Docs Customer feedback via GitHub Issue

Comments

@toddlucas
Copy link

toddlucas commented Jan 7, 2025

Description

I want my API to return an HTTP status code, such as 429, when the limit is reached. The default behavior appeared to be that the response was delayed. All of my tests started to block before returning 200. This happened even after I set RejectionStatusCode on the RateLimiterOptions object.

It took me a while to figure out (with the help of an LLM), that the QueueLimit being non-zero on various limiter options (like fixed) was the problem. If the documentation were updated, I'm sure that would save others some time. Thanks.

Page URL

https://learn.microsoft.com/en-us/aspnet/core/performance/rate-limit?view=aspnetcore-9.0

Content source URL

https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/performance/rate-limit.md

Document ID

bb96b20f-0991-d6de-4d98-192cd469460f

Article author

@tdykstra

Related Issues


Associated WorkItem - 360655

@Rick-Anderson
Copy link
Contributor

@toddlucas can you PR the doc with your suggested addition? Use the pen icon on https://github.com/dotnet/AspNetCore.Docs/blob/main/aspnetcore/performance/rate-limit.md and make a PR, then mention me, add fixes #this issue

@Rick-Anderson Rick-Anderson added reQUEST Triggers an issue to be imported into Quest and removed ⌚ Not Triaged labels Jan 8, 2025
@sequestor sequestor bot added seQUESTered Identifies that an issue has been imported into Quest. and removed reQUEST Triggers an issue to be imported into Quest labels Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aspnet-core/svc performance/subsvc seQUESTered Identifies that an issue has been imported into Quest. Source - Docs.ms Docs Customer feedback via GitHub Issue
Projects
None yet
Development

No branches or pull requests

2 participants