Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebToolsE2E][Aspire] Some strings in the dashboard of Aspire 9.1 are not localized. #6982

Open
v-reinawang opened this issue Dec 23, 2024 · 2 comments · May be fixed by #6984
Open

[WebToolsE2E][Aspire] Some strings in the dashboard of Aspire 9.1 are not localized. #6982

v-reinawang opened this issue Dec 23, 2024 · 2 comments · May be fixed by #6984
Assignees
@adamint
Labels
area-dashboard loc
Milestone
9.1

Comments

@v-reinawang
Copy link

v-reinawang commented Dec 23, 2024 •
edited
Loading

INSTALL STEPS

  1. Clean machine: Win11 x64 23h2
  2. Install VS 17.12.4 (with Aspire 9.0.0)
  3. Install latest Aspire 9.1.0-preview.1.24620.1

REPRO STEPS

  1. Create a new project > .NET Aspire Starter App > .NET 9.0 (Standard Term Support) > Create
  2. Build and F5
  3. Change the display language in Settings

ACTUAL
On the resource page, when hovering over the stop button, "stop/start resource" was not localized.
Image

On the Resources page, "Restart" is not localized.
Image

On the Resources page, "Column width" is not localized.
Image

On the console page, when hovering over the stop button, "stop/start resource" was not localized.
Image

On the console page, "Restart" is not localized.
Image

"Close" is not localized when hovering over the Close button.
Image

EXPECTED
After changing the localization for displayed language, the mentioned strings should be localized.
@v-reinawang
Copy link
Author

This issue is reproduced in the latest Aspire 9.1.0-preview.1.24620.1. This Aspire package has merged #6971.

@adamint adamint linked a pull request Dec 23, 2024 that will close this issue
Open
18 tasks
@adamint adamint self-assigned this Dec 23, 2024
@joperezr joperezr added the untriaged New issue has not been triaged label Jan 7, 2025
@davidfowl davidfowl added this to the 9.1 milestone Jan 13, 2025
@davidfowl davidfowl added area-dashboard and removed untriaged New issue has not been triaged labels Jan 13, 2025
@JamesNK
Copy link
Member

JamesNK commented Jan 22, 2025

@adamint How about this for a simple fix:

We hardcode translations for the built-in commands into the dashboard. That means resource-start, resource-stop, and resource-restart. If we see a command with one of names then we use translations for its text, tooltips, etc. That means the default dashboard experience with its built in commands has translations by default.

3rd parties creating their own commands are very unlikely to go through the work to add translations so I think it is a fine compromise not to support them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamint adamint

Labels
area-dashboard loc
Projects
None yet
Milestone
9.1
Development

Successfully merging a pull request may close this issue.

Allow dynamic localization of command display name and descriptions adamint/aspire
6 participants
@davidfowl @JamesNK @leslierichardson95 @joperezr @adamint @v-reinawang