short.Parse throws FormatException

[Herdo]

Description

I have one of my users reporting an issue with our Blazor WASM app.
After investigating, we found the error being that "-1" cannot be parsed with short.Parse for him.
He's the only user with that issue from about 200 users.

The stacktrace:

blazor.web.js:1 
 crit: Microsoft.AspNetCore.Components.WebAssembly.Rendering.WebAssemblyRenderer[100]
      Unhandled exception rendering component: Format_InvalidStringWithValue, -1
System.FormatException: Format_InvalidStringWithValue, -1
   at System.Number.ThrowFormatException[Char](ReadOnlySpan`1 )
   at System.Number.ThrowOverflowOrFormatException[Char,Int16](ParsingStatus , ReadOnlySpan1 )
   at System.Number.ParseBinaryInteger[Char,Int16](ReadOnlySpan1 , NumberStyles , NumberFormatInfo )
   at System.Int16.Parse(ReadOnlySpan1 , NumberStyles , IFormatProvider )
   at System.Int16.Parse(String , NumberStyles , IFormatProvider )
   at System.Int16.Parse(String )
   at UNITS.Client.Components.EventDetails.RosterCards.<>c.<OnInitializedAsync>b__77_0(KeyValuePair2 m)
   at System.Linq.Enumerable.ToDictionary[KeyValuePair2,GroupNumber,Int32](IEnumerable1 source, Func2 keySelector, Func2 elementSelector, IEqualityComparer1 comparer)
   at System.Linq.Enumerable.ToDictionary[KeyValuePair2,GroupNumber,Int32](IEnumerable1 source, Func2 keySelector, Func`2 elementSelector)
   at UNITS.Client.Components.EventDetails.RosterCards.OnInitializedAsync()
   at Microsoft.AspNetCore.Components.ComponentBase.RunInitAndSetParametersAsync()
   at Microsoft.AspNetCore.Components.RenderTree.Renderer.GetErrorHandledTask(Task , ComponentState )

Reproduction Steps

Not reliably reproduceable on other machines. Here are the steps anyway:

1. Open Blazor WASM app in Microsoft Edge.
2. Request payload via web API from server.
   • Response is {"-1":26}
3. Deserialize response with NSwag generated client to a Dictionary<string, int>.
   • Deserialized dictionary is {{"-1", 26}}
4. Convert deserialized dictionary to Dictionary<Id, int>:

var converted = response.ToDictionary(m => (Id)short.Parse(m.Key), m => m.Value);

Expected behavior

"-1" should be parsed correctly to the Int16 -1.

Actual behavior

System.FormatException is thrown.

Regression?

It still worked on 2025-01-03. It's not working any more since 2025-01-10.
The application is running the same version for both dates, the hosting Docker container wasn't even restarted.

Known Workarounds

For that one user, he can use another browser than Edge.
Edge works for other users.

Configuration

• .NET 8.0
• Windows 11
• x64
• French language version
• Blazor, running in Edge 131.0.2903.112 (Official build) (64-bit)

Other information

No response

[4nonym0us]

The error means you are trying to parse a number using incorrect format.

Use overload, which accepts IFormatProvider if you need to specify the culture explicitly, otherwise Thread.CurrentThread.CurrentCulture is used as a fallback. Not specifying the culture leads to the FormatException for that user because your input doesn't match their culture preferences (it works in different browser for them because they have different language preferences there):

public static short Parse(string s, IFormatProvider? provider)

short.Parse("-1", CultureInfo.CreateSpecificCulture("ar-SA")); // FormatException
short.Parse("؜-1", CultureInfo.CreateSpecificCulture("ar-SA")); // -1

short.Parse("-1", CultureInfo.InvariantCulture); // -1
short.Parse("؜-1", CultureInfo.InvariantCulture); // FormatException

TLDR: Replace short.Parse(m.Key) with short.Parse(m.Key, CultureInfo.InvariantCulture) if your app supports only invariant culture or make sure that your Key is in correct format (if your app is designed to support multiple cultures).

[dotnet-policy-service]

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

[dotnet-policy-service]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

[Herdo]

The error means you are trying to parse a number using incorrect format.

Use overload, which accepts IFormatProvider if you need to specify the culture explicitly, otherwise Thread.CurrentThread.CurrentCulture is used as a fallback. Not specifying the culture leads to the FormatException for that user because your input doesn't match their culture preferences (it works in different browser for them because they have different language preferences there):

public static short Parse(string s, IFormatProvider? provider)

short.Parse("-1", CultureInfo.CreateSpecificCulture("ar-SA")); // FormatException
short.Parse("؜-1", CultureInfo.CreateSpecificCulture("ar-SA")); // -1

short.Parse("-1", CultureInfo.InvariantCulture); // -1
short.Parse("؜-1", CultureInfo.InvariantCulture); // FormatException

TLDR: Replace short.Parse(m.Key) with short.Parse(m.Key, CultureInfo.InvariantCulture) if your app supports only invariant culture or make sure that your Key is in correct format (if your app is designed to support multiple cultures).

Yeah, you're correct. The language is set to Hebrew. Didn't think about RTL issue. Thank you!