Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Check for profile consistency throughout JIT backend #111684

Draft
wants to merge 37 commits into
base: main
Choose a base branch
from
Draft

JIT: Check for profile consistency throughout JIT backend #111684

wants to merge 37 commits into from
+76 −28

Conversation

amanasifkhalid
Copy link
Member

@amanasifkhalid amanasifkhalid commented Jan 21, 2025 •
edited
Loading

Part of #107749.

@amanasifkhalid
Use block weight helpers in more places
32e7735
@amanasifkhalid
Move profile checks to after morph
57b7705
@amanasifkhalid
Move profile checks to after post-morph
3f5f514
@amanasifkhalid
Add metrics
3e89cef
@amanasifkhalid
Remove whitespace change
c9272ba
@amanasifkhalid
Move profile checks to after loop inversion
b73271c
@amanasifkhalid
Move profile checks to after flow opts
174e1bf
@amanasifkhalid
Move profile checks to after loop recognition
22634d9
@amanasifkhalid
Merge branch 'main' into profile-checks-loop-finding
7510444
@amanasifkhalid
Re-enable profile consistency checks
5dbbb8f
@amanasifkhalid
Fix inconsistency in loop finding, block weight phases
6462e26
@amanasifkhalid
Move profile checks to after loop opts
68cc25a
@amanasifkhalid
Move profile checks up to late flow opts
2c9afb4
@amanasifkhalid
Move profile checks up to rationalization
83fb829
@amanasifkhalid
Merge from main
a253111
@amanasifkhalid
Fix bool opts profile prop
69f18cd
@amanasifkhalid
Another bool opt fix
9a577af
@amanasifkhalid
Fix helper expansion
690867f
@amanasifkhalid
Merge branch 'main' into profile-checks-lowering
29f86b8
@amanasifkhalid
New BB helper for computing incoming weight
0ba5519
@amanasifkhalid
Use helper in a few places
6e479bd
@amanasifkhalid
Merge branch 'main' into profile-checks-lowering
12bdafe
@amanasifkhalid
Style
da9ee51
@amanasifkhalid
Always check for profile consistency
5accebe
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 21, 2025
@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-pgo

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

@build-analysis build-analysis bot mentioned this pull request Jan 22, 2025
Open
@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-pgo

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-pgo

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@amanasifkhalid amanasifkhalid changed the title JIT: Always check for profile consistency JIT: Check for profile consistency throughout JIT backend Jan 22, 2025
@amanasifkhalid
Copy link
Member Author

JitStress pipelines are hitting profile consistency asserts in earlier phases. I'll sort these failures out before moving this PR forward; I've opened #111724 to track the work.

This was referenced Jan 23, 2025
Open
Open
@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-pgo, runtime-coreclr libraries-jitstress

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-pgo, runtime-coreclr libraries-jitstress

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr jitstress, runtime-coreclr libraries-pgo, runtime-coreclr libraries-jitstress

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@amanasifkhalid
Copy link
Member Author

/azp run runtime-coreclr libraries-pgo

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amanasifkhalid amanasifkhalid

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amanasifkhalid