-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JIT: Fix stack allocated arrays for NativeAOT #111827
Conversation
if that code path is still not expected in R2R you should leave that assert there, just add !nativeaot |
Done. |
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Is there a case where we don't use |
|
/azp run runtime-nativeaot-outerloop |
Commenter does not have sufficient privileges for PR 111827 in repo dotnet/runtime |
1 similar comment
Commenter does not have sufficient privileges for PR 111827 in repo dotnet/runtime |
/azp run runtime-nativeaot-outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
seems that outerloop is passing now (the failure is unrelated) |
NAOT outerloop failure is
seems unrelated. X86 SPMI failures are timeouts; ditto. |
In R2R we use a separate helper so we don't need the
opts.IsReadyToRun()
check. Otherwise the optimization will be blocked under NativeAOT.Fixes #111822