Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0.1xx] Update dependencies from dotnet/arcade #7149

Merged
merged 15 commits into from
Oct 18, 2023
Merged

[release/8.0.1xx] Update dependencies from dotnet/arcade #7149

merged 15 commits into from
Oct 18, 2023

Conversation

v-wuzhai
Copy link
Member

@v-wuzhai v-wuzhai commented Oct 17, 2023 •
edited
Loading

No description provided.

dotnet-maestro bot and others added 14 commits October 5, 2023 12:44
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
83df5e5 
…004.4

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23504.4

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
fffe602 
…006.1

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23506.1

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
d7f528e 
…006.2

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23506.2

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
19fda4f 
…006.2

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23506.2

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
acf25eb 
…008.1

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23508.1

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
24daecb 
…010.1

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23510.1

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23502.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
fd3df13 
…010.4

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23510.4

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23509.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
87d61c7 
…010.4

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23510.4

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23509.1 (parent: Microsoft.DotNet.Arcade.Sdk
@marcpopMSFT
a whole bunch of new xunit and style cop analyzers were enabled.
c54529b
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
5bb3978 
…010.4

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23510.4

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23509.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
f36b303 
…010.4

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23510.4

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23509.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
6bced82 
…010.4

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23510.4

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23509.1 (parent: Microsoft.DotNet.Arcade.Sdk
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20231…
0b4bbd2 
…010.4

Microsoft.DotNet.Arcade.Sdk
 From Version 8.0.0-beta.23463.1 -> To Version 9.0.0-beta.23510.4

Dependency coherency updates

Microsoft.DotNet.XliffTasks
 From Version 1.0.0-beta.23426.1 -> To Version 1.0.0-beta.23509.1 (parent: Microsoft.DotNet.Arcade.Sdk
@v-wuzhai
Fix a couple of analyzer errors
7a46367
@v-wuzhai v-wuzhai requested review from GangWang01 and a team as code owners October 17, 2023 08:40
@v-wuzhai v-wuzhai mentioned this pull request Oct 18, 2023
Merged
@marcpopMSFT
Copy link
Member

@MiYanni I believe you were looking at some of the analysis warnings. Looks like Jason updated a bunch of tests for that.

@MiYanni
Copy link
Member

MiYanni commented Oct 18, 2023

PERFECT! I was trying to fix these and the .ConfigureAwait(false) ones were broken in the auto-fix resolver in VS. Thank you!!!

@MiYanni MiYanni merged commit 9b57714 into release/8.0.1xx Oct 18, 2023
10 checks passed
@MiYanni MiYanni mentioned this pull request Oct 19, 2023
Merged
@v-wuzhai v-wuzhai deleted the Jason/Fixes#7121 branch October 19, 2023 02:14
@v-wuzhai v-wuzhai mentioned this pull request Oct 20, 2023
Merged
@ViktorHofer
Copy link
Member

This PR consumed the Arcade from the main branch instead of release/8.0: dotnet/arcade@0e89c8d. That's why you got these new analyzers showing up here.

We can keep the test updates but we should trigger a new Arcade subscription update and make sure that the subscription points to the right channel.

@ViktorHofer
Copy link
Member

ViktorHofer commented Oct 20, 2023 •
edited
Loading 

https://github.com/dotnet/arcade (.NET Eng - Latest) ==> 'https://github.com/dotnet/templating' ('release/8.0.1xx')
  - Id: 0d66de4b-fd8f-44dd-a789-08db9e4038dc
  - Update Frequency: EveryDay
  - Enabled: True
  - Batchable: False
  - PR Failure Notification tags:
  - Merge Policies:
    Standard
  - Last Build: 20231018.2 (6a5ca678aef84f34a1fccc46f76623f41da56553)

This is wrong. dotnet/templating's release/8.0.1xx branch must not consume Arcade's main branch as that already targets .NET 9. @marcpopMSFT @mmitche any idea who owns this stuff for templating? We need to make sure that they understand the issue here. Is that @MiYanni ?

Updated the subscription to point to the .NET 8 Eng channel instead and trigger it. Here's the new PR: #7180

@MiYanni
Copy link
Member

MiYanni commented Oct 20, 2023

@ViktorHofer So, @joeloff and myself own Templating now, but clearly, it doesn't have the same configuration that we have for the SDK/Installer repos. I've done some adjustments yesterday, but I wasn't aware of this situation. I'm fairly new to DARC/codeflow, so I might need to work with @joeloff and do a review of the current configuration to see if it makes sense. Thank you for fix this!

@ViktorHofer
Copy link
Member

No worries at all. Feel free to ping me in case you ever need help with codeflow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiYanni MiYanni MiYanni approved these changes

@marcpopMSFT marcpopMSFT marcpopMSFT approved these changes

@GangWang01 GangWang01 Awaiting requested review from GangWang01 GangWang01 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@v-wuzhai @marcpopMSFT @MiYanni @ViktorHofer