Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the search cache to mark it as a release job #8620

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

marcpopMSFT
Copy link
Member

Our builds are getting 1ES alerts that a release task can't be used outside of a release job. Per the instructions on this page, I think this is how we mark the job to be a release job: https://eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/features/releasepipelines/releaseworkflows/releasejob

@marcpopMSFT marcpopMSFT requested a review from a team as a code owner January 6, 2025 18:21
@MiYanni
Copy link
Member

MiYanni commented Jan 6, 2025

@marcpopMSFT

Our builds are getting 1ES alerts that a release task can't be used outside of a release job. Per the instructions on this page, I think this is how we mark the job to be a release job: eng.ms/docs/cloud-ai-platform/devdiv/one-engineering-system-1es/1es-docs/1es-pipeline-templates/features/releasepipelines/releaseworkflows/releasejob

Keep in mind that none of this stuff is "standard" to AzDO. release task isn't a concept that exists in AzDO, nor is release job.

image

I had to spend like 20+ minutes reading the docs to even understand what the point is of this concept. These concepts are completely bespoke to 1ES PT. I continued digging and they do eventually link to the list of tasks they define as "release tasks". It only exists in their template definition: https://dev.azure.com/1ESPipelineTemplates-PPE/_git/1ESPipelineTemplates?path=/v1/1ES.Pipeline.yml&version=GBmain&line=150&lineEnd=295&lineStartColumn=1&lineEndColumn=1&lineStyle=plain&_a=contents

Other pipelines might need changes based on these new restrictions, but I wouldn't know which ones off the top of my head.

@marcpopMSFT
Copy link
Member Author

Internal test build worked so merging.

@marcpopMSFT marcpopMSFT merged commit 89b8b37 into main Jan 7, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants