Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reason for PlaybackActiveTrackChanged event #2426

Open
aman-rohilla opened this issue Jan 1, 2025 · 4 comments
Open

Add reason for PlaybackActiveTrackChanged event #2426

aman-rohilla opened this issue Jan 1, 2025 · 4 comments

Comments

@aman-rohilla
Copy link

aman-rohilla commented Jan 1, 2025

We should be able to know that the current track got changed because of it's playback has ended or some another reason (like some other track got inserted).

For this, we can either add a reason for PlaybackActiveTrackChanged event or introduce another event like PlaybackFinished.

@aman-rohilla aman-rohilla changed the title [Feature Request] Add reason for PlaybackActiveTrackChanged Add reason for PlaybackActiveTrackChanged Jan 1, 2025
@aman-rohilla aman-rohilla changed the title Add reason for PlaybackActiveTrackChanged Add reason for PlaybackActiveTrackChanged event Jan 1, 2025
@lovegaoshi
Copy link
Contributor

its an FR alright.

ur looking at emitPlaybackTrackChangedEvents on android and wtv for apple. u can add a field in the bundle denoting the reason if ud like.

@aman-rohilla
Copy link
Author

Don't know what is an FR.

I can add the reason myself but the android code is hard to understand and navigate. 🙂

@lovegaoshi
Copy link
Contributor

lovegaoshi commented Jan 6, 2025 via email

@aman-rohilla
Copy link
Author

Ok, I can do it myself. Just wanted to bring this issue to attention. If some maintainer works on it, then everybody can benifit from it.
You can close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants