Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: Refactor and align ESQL EsqlQueryRequest and x-core EsqlQueryRequest #119987

Open
costin opened this issue Jan 10, 2025 · 1 comment
Open
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)

Comments

@costin
Copy link
Member

costin commented Jan 10, 2025

To avoid classpath issues, ESQL exposes EsqlQueryRequest/Response in the xpack-core plugin so that other plugins can make requests without having to depend on the xpack-esql plugin itself.
xpack-esql plugin however extend the public class through EsqlQueryRequest which adds more internal state - however in time public options were added but only to this class, without porting them to the xpack-core plugin.

To avoid this situation occurring I propose:

  • renaming xpack-esql EsqlQueryRequest to EsqlInternalQueryRequest
  • move columnar, profile, locale etc.. methods on the super class so other consumer can enable these options.
  • keep the async (waitForCompletion, etc...) and QueryParams/Pragmas internal since exposing them requires moving more classes and it's not clear whether there's a real demand for it at this point.
@costin costin added the :Analytics/ES|QL AKA ESQL label Jan 10, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo)
Projects
None yet
Development

No branches or pull requests

2 participants