You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To avoid classpath issues, ESQL exposes EsqlQueryRequest/Response in the xpack-core plugin so that other plugins can make requests without having to depend on the xpack-esql plugin itself.
xpack-esql plugin however extend the public class through EsqlQueryRequest which adds more internal state - however in time public options were added but only to this class, without porting them to the xpack-core plugin.
To avoid this situation occurring I propose:
renaming xpack-esql EsqlQueryRequest to EsqlInternalQueryRequest
move columnar, profile, locale etc.. methods on the super class so other consumer can enable these options.
keep the async (waitForCompletion, etc...) and QueryParams/Pragmas internal since exposing them requires moving more classes and it's not clear whether there's a real demand for it at this point.
The text was updated successfully, but these errors were encountered:
To avoid classpath issues, ESQL exposes
EsqlQueryRequest/Response
in the xpack-core plugin so that other plugins can make requests without having to depend on the xpack-esql plugin itself.xpack-esql plugin however extend the public class through
EsqlQueryRequest
which adds more internal state - however in time public options were added but only to this class, without porting them to the xpack-core plugin.To avoid this situation occurring I propose:
EsqlQueryRequest
toEsqlInternalQueryRequest
The text was updated successfully, but these errors were encountered: