Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duty calculation is wrong with unbalanced validator set #211

Open
pk910 opened this issue Jan 9, 2025 · 1 comment
Open

Duty calculation is wrong with unbalanced validator set #211

pk910 opened this issue Jan 9, 2025 · 1 comment

Comments

@pk910
Copy link
Member

pk910 commented Jan 9, 2025

Dora's duty calculation can produce invalid proposer duties with unbalanced validator sets:
image

all blocks were proposed by their canonical proposer, but dora expected different proposers for slot 2905, 2898 & 2896.
the canonical proposers for those slots were all validator 32, which got a top up deposit of 2048 ETH applied just in the epoch before.
given, that the effective balance has a high effect of the proposer selection, it seems like the proposer duties were calculated with the previous EB of validator 32 (32ETH)

@pk910
Copy link
Member Author

pk910 commented Jan 9, 2025

Dora fixed this issue by itself. Once epoch 90 in the screenshot above got finalized, the invalid missed blocks disappeared.

That's probably because the proposer duties have been recalculated by the finalization routine. This time with a proper validator balances.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant