Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Angular i18n recommendation #569

Open
emclaug2 opened this issue Jul 13, 2022 · 3 comments
Open

Adjust Angular i18n recommendation #569

emclaug2 opened this issue Jul 13, 2022 · 3 comments
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature user-reported This was reported by a user outside the maintainers team.

Comments

@emclaug2
Copy link
Contributor

Describe the desired behavior

Talking to the IPM team, Angular's deafult i18n option should be the first item recommended in our list.

Describe the current behavior

ngx-translate is the first item recommended today.

Is this request related to a current issue?

No

Additional Context
@emclaug2 emclaug2 added needs-review Issues that we would like to revisit/review good first issue A good issue for first-time contributors labels Jul 13, 2022
@bkarambe
Copy link
Contributor

Revisit https://brightlayer-ui.github.io/patterns/internationalization to double check if ng i18n tools requires separate builds for languages.
Add pros and cons for both.

@bkarambe bkarambe added enhancement Request for improvement or new feature user-reported This was reported by a user outside the maintainers team. and removed needs-review Issues that we would like to revisit/review good first issue A good issue for first-time contributors labels Jul 20, 2022
@daileytj
Copy link
Contributor

Have a conversation with Jonathan to get some information around how these translation libraries are used and potentially re-order the list of recommended tools on doc-it

@bkarambe
Copy link
Contributor

Have a conversation with Jonathan to get some information around how these translation libraries are used and potentially re-order the list of recommended tools on doc-it

@emclaug2 @daileytj Any update on this?

@joebochill joebochill added the brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
brightlayer-ui Used to identify Brightlayer UI platform issues for easy filtering enhancement Request for improvement or new feature user-reported This was reported by a user outside the maintainers team.
Milestone
No milestone
Development

No branches or pull requests
4 participants
@emclaug2 @daileytj @bkarambe @joebochill