Dev-Only Announcement Banners do not work on deployed site #588
Labels
brightlayer-ui
Used to identify Brightlayer UI platform issues for easy filtering
bug
Something not working as expected
good first issue
A good issue for first-time contributors
Describe the bug
Announcements that are specified as devOnly do not appear on the deployed version of the dev site.
What is the expected behavior?
These banners should be visible
What are the steps to reproduce?
Screenshots / Screen recording
Code snippet / Link to minimum reproduction example
https://brightlayer-ui-dev.github.io/
environment === 'production'
will always return true.Your environment information
Suggested fix
This issue for this is because we are using the process.env.NODE_ENV to determine whether we are dev or master, which is incorrect. When the site is deployed to github pages, it's a production build (regardless of whether we deploy to master or dev). This needs to be updated to use a proper environment variable in CircleCI to determine the branch we are on.
Anything else to add?
There is also a gap that appears on the MASTER version of the deployed site when there is a devOnly version
The text was updated successfully, but these errors were encountered: