Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review and rewrite more explicit assertion logic for f3_test.go #818

Open
masih opened this issue Jan 10, 2025 · 0 comments
Open

Review and rewrite more explicit assertion logic for f3_test.go #818

masih opened this issue Jan 10, 2025 · 0 comments

Comments

@masih
Copy link
Member

masih commented Jan 10, 2025

The f3_test.go tests the upper level F3 functionality (i.e. including pubub sub-systems, manifest propagation, etc.). It is a valuable suit of tests that have caught a number of issues in the past.

These tests, however, loosely rely on a fake clock: The EC clock is fake but that does not offer control over the progress of GPBFT itself. This is OK but it means the test should be more explicit about asserting things. For example, it is better to assert that nodes have reached some instance and a specific phase/round. As a result, it has become time consuming to debug issues when these tests fail.

There are adhoc sleeps in a number of places that should ideally be removed once a more precise eventual assertion is made about the state of each node in the test environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant