Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove h5py version restriction once 3.13 version is available #3907

Open
JHopeCollins opened this issue Dec 5, 2024 · 4 comments
Open

Remove h5py version restriction once 3.13 version is available #3907

JHopeCollins opened this issue Dec 5, 2024 · 4 comments
Assignees

Comments

@JHopeCollins
Copy link
Member

firedrake/pyproject.toml

Lines 21 to 23 in 97f2cb4

# TODO: We are only using our fork here because the most recent PyPI release
# does not yet work with build isolation for Python 3.13. Once a version
# newer than 3.12.1 is released we can revert to simply using "h5py".

@francesco-ballarin
Copy link
Member

francesco-ballarin commented Dec 5, 2024

Suggestion: change

  "h5py @ git+https://github.com/firedrakeproject/h5py.git",

into something like

  "h5py @ git+https://github.com/firedrakeproject/h5py.git; python_version >= '3.13'",
  "h5py; python_version < '3.13'",

just like you have in the lines above the ones you mention. Forcing everyone to use h5py from the fork just because of python 3.13 is a very though requirement.

@JHopeCollins
Copy link
Member Author

Hi @francesco-ballarin, yes I think that's a good suggestion.
@connorjward this is from the mac runners PR, what do you think? Can you add it in?

@connorjward
Copy link
Contributor

connorjward commented Dec 5, 2024

Yes this is a good point. I will make the change.


Done.

@JHopeCollins
Copy link
Member Author

Thanks. I'll keep the issue open to remind us to remove the restrictions once possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants