Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prompts for user to fix up collection (step 3) if collection looks noisy (step 7) #4

Open
annietaylor opened this issue Nov 17, 2020 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@annietaylor
Copy link
Collaborator

How should we prompt people to go back to step 3 if some years look bad upon reviewing them in step 7?

@jdbcode
Copy link
Collaborator

jdbcode commented Nov 21, 2020

I suppose in the readme we could include a couple images showing bad composites "if you see any of these issues, go back to step 3, and for the offending year(s), try to identify the image(s) causing the problem and add their IDs to the list of images to exclude. Rerun steps 4-7" (if people are rerunning steps, they may need to delete existing exported assets - I can't remember - if so, the Colab notebook for creating directories also has some code to automate deletion from the directories).

@jdbcode
Copy link
Collaborator

jdbcode commented Nov 21, 2020

I can take the task of producing some bad image composites and writing a blurb for each about what is wrong. After I have them would you mind editing the readme with something similar to the instructions above, if you think it is appropriate.

@jdbcode jdbcode self-assigned this Nov 21, 2020
@jdbcode jdbcode added the documentation Improvements or additions to documentation label Nov 21, 2020
@annietaylor
Copy link
Collaborator Author

That sounds good to me! I'll also look into a good process for deleting assets, which I believe we will have to do.

@annietaylor
Copy link
Collaborator Author

Added this to the README.md file of the DecEditsAT branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants