Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from flow to typescript #772

Open
machour opened this issue Apr 12, 2018 · 4 comments
Open

Switch from flow to typescript #772

machour opened this issue Apr 12, 2018 · 4 comments

Comments

@machour
Copy link
Member

machour commented Apr 12, 2018

As we were going through #770 with @housseindjirdeh, we both emitted the desire of ditching flow in favor of typescript.

I personally struggled with flow while trying to enforce types, using VS Code. Validation sometimes takes a few seconds, and the whole thing seems a bit sketchy to me.

Of course, this is up for debate :)

@housseindjirdeh
Copy link
Member

I also have a preference for TS for a few reasons (one being a smoother editor experience). Thanks for logging this mate - and happy to hear anybody else's opinions on this as well 💬

@G2Jose
Copy link
Contributor

G2Jose commented May 4, 2019

Would love to see this as well! Lmk if we're cool with me creating an initial PR for this.

@alejandronanez
Copy link
Member

alejandronanez commented May 5, 2019

Whew, this is quite an old issue 😅.

Before any work is made here, let’s think about what real specific problems would typescript fix vs flow? Would it be worth it to make the change?

This amazing article from Eric Elliot talks about adopting typescript on big projects https://medium.com/javascript-scene/the-typescript-tax-132ff4cb175b I think it’s a good read before making this effort.

@chinesedfan
Copy link
Member

Agreed with @alejandronanez. The main difference between them is that flow supports to be used progressively and it is already there. If created a new project, I will choose Typescript. And I don't think we can gain much benefits and have enough time to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants