Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hex packages should not leak absolute path in .erl -file "directives" #4141

Open
inoas opened this issue Jan 2, 2025 · 1 comment
Open
Labels
bug Something isn't working help wanted Contributions encouraged priority:high

Comments

@inoas
Copy link
Contributor

inoas commented Jan 2, 2025

Currently erlang files export the full path as it was available on the developer machine that ran gleam publish.

Current implementation

-file("/Users/USERNAME/SOME/PATH/some_lib_or_app/src/some_lib_or_app.gleam", 26).
-spec my_fun(boolean(), fun(() -> FVC), fun(() -> FVC)) -> FVC.
my_fun(Var1, Var2, Var3) ->
% ...

Expected implementation

-file("some_lib_or_app/src/some_lib_or_app.gleam", 26).
-spec my_fun(boolean(), fun(() -> FVC), fun(() -> FVC)) -> FVC.
my_fun(Var1, Var2, Var3) ->
% ...
@lpil
Copy link
Member

lpil commented Jan 3, 2025

I agree, thank you.

@lpil lpil added help wanted Contributions encouraged priority:high bug Something isn't working labels Jan 3, 2025
oneness added a commit to BirkeyCo/gleam that referenced this issue Jan 9, 2025
oneness added a commit to BirkeyCo/gleam that referenced this issue Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Contributions encouraged priority:high
Projects
None yet
Development

No branches or pull requests

2 participants