Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtar::ZipArchive can't open zip files which weren't properly terminated #3

Open
bdice opened this issue Dec 8, 2014 · 1 comment
Open
Labels
bug Something isn't working minor

Comments

@bdice
Copy link
Member

bdice commented Dec 8, 2014

Original report by Matthew Spellings (Bitbucket: mspells, GitHub: klarh).


It seems feasible (at least for reading, and possibly for append, depending on miniz's internal state) to scan through all files in an archive if the central directory is not found.

@bdice
Copy link
Member Author

bdice commented Dec 9, 2014

Original comment by Matthew Spellings (Bitbucket: mspells, GitHub: klarh).


On the other hand, if it is only opened for reading, we would never get the opportunity to fix the central directory, so the file would always open slowly (and we might as well use tarfiles) without running gtar.fix.

@bdice bdice added minor bug Something isn't working labels Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working minor
Projects
None yet
Development

No branches or pull requests

1 participant