gconv.Struct: unexpected behaviour when conv to a string to list

[QisFj]

Go version

go version go1.23.4 darwin/arm64

GoFrame version

v2.8.2

Can this bug be reproduced with the latest release?

Option Yes

What did you do?

func TestConv(t *testing.T) {
	type Param struct {
		List []int `json:"list"`
	}
	data := map[string]any{
		"list": "[a]",
	}
	var p Param
	err := gconv.Struct(data, &p)
	fmt.Println(err)

	fmt.Printf("%#v\n", p)
}

What did you see happen?

I got err==nil and List = [0]

What did you expect to see?

i expected got err != nil ; at least get len(List) == 0.

I guess the reason is gf treat the "[a]" as a object. and when trying to set an object to list, will set it as a element. like []any{"[a]"}; and then trying to conver []any{"[a]"} to a []int, then use the default value 0, since it can't parse "[a]" as a number.

more input output:

• "[1, 2]" => []int{1, 2}
• "[1, \"2\"]" => []int{0}

by the way, if the List is not []int, but []*int. It will return an error, which says failed to conv int to *int. I guess its another bug..

[QisFj]

By the way, i don't found any document says what will happend using gconv on a list.

Hope can add some document about it. Or if i missed out it. and i’m very thankful for anyone can paste a link here..

[gqcn]

Let me have a check.

[gqcn]

@QisFj Hello, I see the problem is that package gconv ignores the converting error and assigns the converting failed value (default type value) for struct attribute. This is the designed and expected behavior in older version of goframe.

We're planning improve such behavior by adding internal do* functions that do the real converting logic and return the error if failed other than current public converting functions that eat the error. The Scan function can call the do* functions to implement its converting. The do* functions were ready implemented in branch feat/v2.9.0.

Here's the code snips for improvement example:

1. Scan would call Convert function to implement basic types converting:

   gf/util/gconv/gconv_convert.go

   Line 23 in 1b4ebc0

   func Convert(fromValue interface{}, toTypeName string, extraParams ...interface{}) interface{} {

   )
2. Convert would call Ints function to implement []int converting:

   gf/util/gconv/gconv_convert.go

   Line 193 in 1b4ebc0

   return Ints(in.FromValue)

3. Ints would call Int function to implement int converting:

   gf/util/gconv/gconv_slice_int.go

   Line 157 in 1b4ebc0

   return []int{Int(any)}

4. But the Int function would return default type value 0 if any error occurs during its internal converting, it so should replace Int function here with doInt function that would return any error during converting:

   gf/util/gconv/gconv_int.go

   Line 94 in a5c8b96

   func doInt64(any any) (int64, error) {

5. So do the other types converting.

We would be very appreciated if any friend can submit such contribution to improve function Scan.

[github-actions]

Hello @QisFj. We like your proposal/feedback and would appreciate a contribution via a Pull Request by you or another community member. We thank you in advance for your contribution and are looking forward to reviewing it!
你好 @QisFj。我们喜欢您的提案/反馈，并希望您或其他社区成员通过拉取请求做出贡献。我们提前感谢您的贡献，并期待对其进行审查。