Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only print internal Faro logs to the console when in debug mode #740

Open
codecapitano opened this issue Nov 14, 2024 · 0 comments
Open
Assignees
Labels
improvement Request a change of an existing feature

Comments

@codecapitano
Copy link
Collaborator

codecapitano commented Nov 14, 2024

Why

The internal Faro logger always prints logs to the console independent of the environment.
This affect enabled log types like console.error.

Also, those logs get captured by the console instrumentation and are sent as logs/errors.
This can clutter a customers observability with a lot of logs for example if users use an ad-blocker which causes a console.error log.

What

  • Only print Faro logs to the console when in debug mode
  • Only sent Faro signals for console.* messages when in debug mode?
@codecapitano codecapitano added the improvement Request a change of an existing feature label Nov 14, 2024
@codecapitano codecapitano self-assigned this Jan 7, 2025
@codecapitano codecapitano reopened this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Request a change of an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant