Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: Support UpstreamTlsContext.sni with XdsChannelCredentials #11784

Open
ejona86 opened this issue Dec 26, 2024 · 0 comments
Open

xds: Support UpstreamTlsContext.sni with XdsChannelCredentials #11784

ejona86 opened this issue Dec 26, 2024 · 0 comments
Assignees
Milestone

Comments

@ejona86
Copy link
Member

ejona86 commented Dec 26, 2024

gRFC A29 added XdsChannelCredentials, but the gRFC explicitly ignored the sni field. @dvilaverde in #11750 needs sni, so this issue was split out to track it. We'll need a small gRFC.

The current implementation is sending sni based on the original target instead of not sending any SNI. That's not good as it could cause a user to unknowingly depend on the incorrect behavior. So we do need to at least disable SNI in the short-term. But it seems the work to disable SNI is most of the work to support sni. (Even when we support sni we need to support disabling SNI; if the field is empty that implies SNI is disabled.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant