Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--skip-archived-repos does not filter all archived repos #158

Closed
schmidlidev opened this issue Jan 3, 2025 · 0 comments · May be fixed by #157
Closed

--skip-archived-repos does not filter all archived repos #158

schmidlidev opened this issue Jan 3, 2025 · 0 comments · May be fixed by #157

Comments

@schmidlidev
Copy link

schmidlidev commented Jan 3, 2025 •
edited
Loading

Describe the bug
A clear and concise description of what the bug is.

--skip-archived-repos only skips some but not all archived repos.

To Reproduce
Steps to reproduce the behavior:

./git-xargs --dry-run --skip-archived-repos --branch-name=foo --github-org=gruntwork-io touch hello.txt

Observe output

All repos that were filtered out with the --skip-archived-repos flag

┌───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
| Repo name                                 | Repo URL                                                                  |
| intro-to-terraform                        | https://github.com/gruntwork-io/intro-to-terraform                        |
| --------------------------------------------------------------------------------------------------------------------- |
| terraform-aws-couchbase                   | https://github.com/gruntwork-io/terraform-aws-couchbase                   |
| --------------------------------------------------------------------------------------------------------------------- |
| terraform-google-gke                      | https://github.com/gruntwork-io/terraform-google-gke                      |
| --------------------------------------------------------------------------------------------------------------------- |
| terraform-kubernetes-helm                 | https://github.com/gruntwork-io/terraform-kubernetes-helm                 |
| --------------------------------------------------------------------------------------------------------------------- |
| terraform-google-sql                      | https://github.com/gruntwork-io/terraform-google-sql                      |
| --------------------------------------------------------------------------------------------------------------------- |
| terraform-google-static-assets            | https://github.com/gruntwork-io/terraform-google-static-assets            |
| --------------------------------------------------------------------------------------------------------------------- |
| terraform-google-load-balancer            | https://github.com/gruntwork-io/terraform-google-load-balancer            |
| --------------------------------------------------------------------------------------------------------------------- |
| terraform-google-ci                       | https://github.com/gruntwork-io/terraform-google-ci                       |
| --------------------------------------------------------------------------------------------------------------------- |
| pipelines-status-update                   | https://github.com/gruntwork-io/pipelines-status-update                   |
| --------------------------------------------------------------------------------------------------------------------- |
| pipelines-preflight-action                | https://github.com/gruntwork-io/pipelines-preflight-action                |
| --------------------------------------------------------------------------------------------------------------------- |
| pipelines-aws-execute                     | https://github.com/gruntwork-io/pipelines-aws-execute                     |
| --------------------------------------------------------------------------------------------------------------------- |
| pipelines-baseline-account-action         | https://github.com/gruntwork-io/pipelines-baseline-account-action         |
| --------------------------------------------------------------------------------------------------------------------- |
| pipelines-provision-access-control-action | https://github.com/gruntwork-io/pipelines-provision-access-control-action |
└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

This is 13 repos, however gruntwork-io actually has 18 archived repos at this time. For example, terraform-google-network is an archived repo which is not present in this list, and is present in the other output sections for repos which will be processed.

The exact repos which are or are not filtered may depend on where exactly they show up in the paginated API results, so these results might not be exactly reproducible, but any org with a sufficient concentration of archived repos should be able to demonstrate this issue.

Expected behavior
A clear and concise description of what you expected to happen.

All archived reps should be filtered out.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

I have opened a PR to fix this issue. #157
@schmidlidev schmidlidev mentioned this issue Jan 3, 2025
Open
4 tasks
@eric-Grunt eric-Grunt closed this as not planned Won't fix, can't repro, duplicate, stale Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: --skip-archived-repos does not filter correctly schmidlidev/git-xargs
2 participants
@schmidlidev @eric-Grunt