Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing category and label instead of target and target-properties #184

Open
nmdgent-jefverme opened this issue Apr 22, 2022 · 2 comments
Open

Comments

@nmdgent-jefverme
Copy link

Hello everyone

Is there a way to track a custom event and pass a category and label without those two values being passed as target and target-properties?

@Shinigami92
Copy link
Contributor

Does not look like it 🤔

https://github.com/gtm-support/core/blob/fae0afa9b23a5870b4c23a5b27cd077b1f75b394/src/gtm-support.ts#L188-L242

I'm not even sure what this is doing 😅 because I just took over this package from vue-gtm history to maintain it.

Maybe you could provide a second optional parameter for trackEvent where you can override the keys? That way, it will not be a breaking change.

@Shinigami92
Copy link
Contributor

If you are still interested in this, you should have a look into #197
Maybe you can get some inspirations from that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants