feat: 🎸 Added GCP host sets and hosts #2658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plugin (#2627) * chore: 🤖 GCP plugin support
gcp plugin creation and mirage changes
* chore: 🤖 add worker_filter field, updates to helper text
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cameronperera
previously approved these changes
Jan 10, 2025
|
apologies for losing this commit, thanks for recreating this 😿 |
DhariniJeeva
previously approved these changes
Jan 10, 2025
DhariniJeeva
dismissed stale reviews from cameronperera and themself
The merge-base changed after approval.
DhariniJeeva
force-pushed
the
llb/gcp-plugin
branch
from
07d4ac1 to
390d179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Closes: https://hashicorp.atlassian.net/browse/ICU-15994
Note this is a duplicate of #2655 which got accidentally lost in a force push.
Description
This adds support for GCP host sets and hosts. I also updated the styles for the host page in all 3 dynamic catalogs to add some space to the dynamic inputs. Will add tests.
Screenshots (if appropriate)
Host Set page:
Host List page:
Host page:
AWS host page:
AWS before:
How to Test
Checklist
[ ] I have added JSON response output for API changes[ ] I have added steps to reproduce and test for bug fixes in the description