Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support option for persistent views (or tables) in read_parquet() #10519

Open
1 task done
cboettig opened this issue Nov 21, 2024 · 1 comment
Open
1 task done
Labels
feature Features or general enhancements

Comments

@cboettig
Copy link

cboettig commented Nov 21, 2024

Is your feature request related to a problem?

read_parquet creates only temporary views

What is the motivation behind your request?

I would like to be able to pre-populate a local duck.db database with VIEWs that can be accessed by other backends that also use duckdb, without resorting to raw SQL code.

Describe the solution you'd like

Most of the time this is indeed the ideal default behavior, but sometimes it would be nice to have a persistent views. it would be nice if we had an optional argument in the read_parquet().

At very least, the read_parquet() documentation should be more precise in stating it creates a temporary view, not a view, not a table, not a temporary table.

What version of ibis are you running?

9.5.0

What backend(s) are you using, if any?

duckdb

Code of Conduct

  • I agree to follow this project's Code of Conduct
@cboettig cboettig added the feature Features or general enhancements label Nov 21, 2024
@jc-5s
Copy link

jc-5s commented Jan 10, 2025

This would be useful to us too, and also applies to other .read_xxx methods in duckdb backend (and possibly other backends)

Would a PR that does the following for duckdb backend be acceptable as a start point?

  • rename _get_temp_view_definition to _get_view_definition and add an arg "temporary=True"
  • rename _create_temp_view to _create_view and add an arg "temporary=True", pass to _get_view_definition
  • modify read_json, read_csv, read_parquet, read_postgres, read_mysql methods: add a temporary_view=True arg

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Features or general enhancements
Projects
Status: backlog
Development

No branches or pull requests

2 participants