Move from OrderedSet to IdentifiedArrayOf

[LePips]

I've long thought about this but think we're going to run into this issue soon, especially with item deletion and updating throughout the app. I've run into some implementation issues while working on static notification payloads, and this will help with that.

We are very susceptible to the following structure, where our items have a ton of optionally-typed properties. In some contexts some properties may be set or not but we actually care about id equivalence.

struct MyItem: Hashable {
    
    let id: String?
    let name: String?
    let otherValue: Int?
}

let foo = MyItem(id: "123", name: "foo", otherValue: 123)
let bar = MyItem(id: "123", name: nil, otherValue: nil)

// false, but we actually care about the IDs
print(foo.hashValue == bar.hashValue)

We should migrate to swift-identified-collections instead for things like PagingLibraryViewModel and other contexts where we currently use OrderedSet to represent BaseItemDto, BaseItemPerson, and other items that conform to Identifiable.

[LePips]

Oof, this requires a bit of thinking for my CollectionHStack and CollectionVGrid packages to take Hashable or Identifiable elements...

[JPKribs]

@LePips I found a new one. Selecting See All from the ItemView for Cast & Crew results in:

I tried some other similar locations like Similar Items / Recommendations, Search > See All, & the Home View See All. All of these work but give me:

Accessing StateObject's object without being installed on a View. This will create a new instance each time.

I did some digging and it looks like every on of these appropriately uses viewModel.elements which is formatted as IdentifiedArray<Int, Element>. Only Cast & Crew is just a pure [BaseItemPerson].

[LePips]

Ah, good catch. Fixed in #1354.

For the runtime warning, that's always kind of been an issue when working with Stinsen. However since we'll be moving away from it I haven't thought about what it's warning about much but we shouldn't have to worry about it for much longer.

[JPKribs]

@LePips Do you think this is related: #1368? Otherwise, I can start looking at this on my end!

[LePips]

Sadly yes it's related but it should all be in my CollectionHStack project. The sample project that I have in the project works on iPadOS so I'm bugged that there's an issue here.

The fact that the data source is an IdentifiedArray shouldn't mean anything, but I've seen weirder things.

Edit: there is a bug in my project when the data updates and how things get laid out. Seems tricky.