Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EvictionPressureTransitionPeriod will silently default 0s to 5m #129548

Open
kannon92 opened this issue Jan 9, 2025 · 2 comments · May be fixed by #129549
Open

EvictionPressureTransitionPeriod will silently default 0s to 5m #129548

kannon92 opened this issue Jan 9, 2025 · 2 comments · May be fixed by #129549
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@kannon92
Copy link
Contributor

kannon92 commented Jan 9, 2025

What happened?

EvictionPressureTransitionPeriod will silently overwrite user specfied values of 0s.

What did you expect to happen?

We should have API documentation and website documentation that 0s is not allowed for this and will be overriden to 5 m.

How can we reproduce it (as minimally and precisely as possible)?

Use EvictionPressureTransitionPeriod of 0s and it will actually default to 5m.

Anything else we need to know?

https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/config/v1beta1/defaults.go#L236-#L238

Kubernetes version

All

Cloud provider

All

OS version

NA

Install tools

NA

Container runtime (CRI) and version (if applicable)

NA

Related plugins (CNI, CSI, ...) and versions (if applicable)

NA
@kannon92 kannon92 added the kind/bug Categorizes issue or PR as related to a bug. label Jan 9, 2025
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2025
@kannon92
Copy link
Contributor Author

kannon92 commented Jan 9, 2025

/remove-kind bug
/kind documentation
/sig node

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. sig/node Categorizes an issue or PR as relevant to SIG Node. and removed kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 9, 2025
@kannon92 kannon92 linked a pull request Jan 9, 2025 that will close this issue
Open
@kannon92
Copy link
Contributor Author

kannon92 commented Jan 9, 2025

/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add documentation that 0s duration will be overwritten for 5m kannon92/kubernetes
2 participants
@kannon92 @k8s-ci-robot