Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The install link for rpm package does not work. #20197

Open
indikafern opened this issue Jan 3, 2025 · 7 comments
Open

The install link for rpm package does not work. #20197

indikafern opened this issue Jan 3, 2025 · 7 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. os/linux packaging/rpm Red Hat/Fedora (rpm) packaging issues

Comments

@indikafern
Copy link

What Happened?

The install link mentioned in the installation guide does not work.
curl -LO https://github.com/kubernetes/minikube/releases/latest/download/minikube-latest.x86_64.rpm

Attach the log file

Link not found

Operating System

Redhat/Fedora

Driver

N/A

@princebillygk
Copy link

The non-working download link is mentioned in here:
Minikube

In case anyone face the same issue, you can also download it from here until the issue is fixed:
Minikube release page

@indikafern
Copy link
Author

indikafern commented Jan 6, 2025 via email

@dem4gus
Copy link

dem4gus commented Jan 7, 2025

Just ran into this same problem, here's the response from Github. It's sending a redirect to https://github.com/kubernetes/minikube/releases/download/v1.34.0/minikube-latest.x86_64.rpm instead of https://github.com/kubernetes/minikube/releases/download/v1.34.0/minikube-1.34.0-0.x86_64.rpm:

$ curl -I https://github.com/kubernetes/minikube/releases/latest/download/minikube-latest.x86_64.rpm
HTTP/2 302
server: GitHub.com
date: Tue, 07 Jan 2025 16:50:50 GMT
content-type: text/html; charset=utf-8
vary: X-PJAX, X-PJAX-Container, Turbo-Visit, Turbo-Frame, Accept-Encoding, Accept, X-Requested-With
location: https://github.com/kubernetes/minikube/releases/download/v1.34.0/minikube-latest.x86_64.rpm

I assume other links on that page that have versions in the filename are also having the same problem, such as https://github.com/kubernetes/minikube/releases/latest/download/minikube_latest_amd64.deb

EDIT: It appears it was added in this commit to update the download links from Google Cloud storage to the Github release page.

@afbjorklund
Copy link
Collaborator

There is a difference between the regular hack/jenkins/release_build_and_upload.sh (to GCS) and hack/jenkins/release_github_page.sh, in that the "latest" copies of the packages are not uploaded to GitHub.

# unversioned names to avoid updating upstream Kubernetes documentation each release
cp "out/minikube_${DEB_VERSION}-0_amd64.deb" out/minikube_latest_amd64.deb
cp "out/minikube_${DEB_VERSION}-0_arm64.deb" out/minikube_latest_arm64.deb
cp "out/minikube-${RPM_VERSION}-0.x86_64.rpm" out/minikube-latest.x86_64.rpm
cp "out/minikube-${RPM_VERSION}-0.aarch64.rpm" out/minikube-latest.aarch64.rpm

Excluded here:

# Upload all end-user assets other than preload files, as they are release independent
for file in $( find out \( -name "minikube[_-]*" -or -name "docker-machine-*"  \) -and ! -name "*latest*"); do

@afbjorklund
Copy link
Collaborator

afbjorklund commented Jan 7, 2025

To make matters worse, the download command is missing important flags like --fail so it always succeeds.

curl -LO https://github.com/kubernetes/minikube/releases/latest/download/minikube-latest.x86_64.rpm

@afbjorklund
Copy link
Collaborator

Same problem, for deb:

@afbjorklund afbjorklund changed the title The install link does not work. The install link for rpm package does not work. Jan 7, 2025
@afbjorklund afbjorklund added os/linux packaging/rpm Red Hat/Fedora (rpm) packaging issues kind/bug Categorizes issue or PR as related to a bug. labels Jan 7, 2025
@medyagh
Copy link
Member

medyagh commented Jan 8, 2025

we changed the the URLS to the github but the old url should work,
sorry about that, we should ensure to publish the RPM assets to the github as well

@ComradeProgrammer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. os/linux packaging/rpm Red Hat/Fedora (rpm) packaging issues
Projects
None yet
Development

No branches or pull requests

6 participants