[Bug] When using console command generate:dimension it always generates column type of INTEGER(11) DEFAULT 0 NULL

[mikkeschiren]

What happened?

When using the console command to generate a new dimension, in this case a visit dimension, and you provide any valid input of column type, it always ends up beeing INTEGER(11) DEFAULT 0 NULL in the generated dimension.

What should happen?

The generate command should output the column type provided.

How can this be reproduced?

Run ./console generate:dimension (first I have created a dummy plugin). When providing the input of column type, it ends out always beeing INTEGER(11) DEFAULT 0 NULL.

Matomo version

5.2.1

PHP version

8.2.27

Server operating system

Linux

What browsers are you seeing the problem on?

No response

Computer operating system

No response

Relevant log output

No response

Validations

• Read our Contributing Guidelines.
• Follow our Security Policy.
• Check that there isn't already an issue that reports the same bug to avoid creating duplicates.
• The provided steps to reproduce is a minimal reproducible of the Bug.

[mikkeschiren]

If you do create an action dimension - you get the column type you asked for.

[mikkeschiren]

It seems that the string replacement is wrong, in the generate command it looks for INTEGER(11) DEFAULT 0 NOT NULL in the ExampleTracker it is INTEGER(11) DEFAULT 0 NULL.

[mikkeschiren]

https://github.com/matomo-org/matomo/blame/5.x-dev/plugins/ExampleTracker/Columns/ExampleVisitDimension.php#L41
https://github.com/matomo-org/matomo/blob/5.x-dev/plugins/CoreConsole/Commands/GenerateDimension.php#L55C33-L55C64

[mikkeschiren]

Suggested fix: #22909

[sgiehl]

fixed with #22909