Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reading metadata from workspace Cargo.toml also #1

Open
mcgoo opened this issue Feb 2, 2021 · 0 comments
Open

Allow reading metadata from workspace Cargo.toml also #1

mcgoo opened this issue Feb 2, 2021 · 0 comments

Comments

@mcgoo
Copy link
Owner

mcgoo commented Feb 2, 2021

No description provided.

waych added a commit to waych/cargo-vcpkg that referenced this issue Jun 12, 2021
It looks like @mcgoo was adding the ability to specify vcpkg
dependencies at the workspace manifest level.
combine_deps_from_all_crates_and_workspace is a new test that is meant
to cover this case, though as is it doesn't work.

Looking more closely, I see that the values nested under 'xworkspace'
are getting dropped by `cargo metadata` completely.  Changing these to
be in the 'workspace' namespace makes them show up in the metadata
output; however, to process that metadata, presumably we still need to
have a root crate that indicates which git rev to use for the vcpkg tree.

Given that currently pointing cargo vcpkg at a workspace base is
currently incomplete (see mcgoo#1 and
run_on_workspace_fails()), disabling the test for now seems preferable
in order to allow a release.
@waych waych mentioned this issue Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant