Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate not using UnitTestResult from adapter and instead use TestResult from framework #4614

Closed
Youssef1313 opened this issue Jan 10, 2025 · 0 comments · Fixed by #4686
Closed

Investigate not using UnitTestResult from adapter and instead use TestResult from framework #4614

Youssef1313 opened this issue Jan 10, 2025 · 0 comments · Fixed by #4686
Assignees
@Youssef1313
Labels
In-PR
Milestone
MSTest 3.8 / Plat...

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Jan 10, 2025 •
edited
Loading

Currently, we do create TestResult from TestFramework, then we convert that to UnitTestResult (adapter), then convert that back to TestResult from VSTest object model. I think we can keep the TestResult from TestFramework all the way, and convert it directly to VSTest's TestResult without needing UnitTestResult at all.

#4591 has a PoC that is reverted to move forward with #4591 faster. We should investigate bringing it back.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
In-PR
Projects
None yet
Milestone
MSTest 3.8 / Platform 1.6
Development

Successfully merging a pull request may close this issue.

Avoid using UnitTestResult and use TestResult directly Youssef1313/testfx
1 participant
@Youssef1313