Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Always open site in this Container" breaking common oauth workflows #2653

Open
2 tasks done
timon-michel-scopevisio opened this issue Jul 31, 2024 · 4 comments
Open
2 tasks done
Labels
bug Something is broken! Component: Site Assignment Issues related to assigning a site to a container

Comments

@timon-michel-scopevisio

Before submitting a bug report

  • I updated to the latest version of Multi-Account Container and tested if I can reproduce the issue
  • I searched for existing reports to see if it hasn't already been reported

Step to reproduce

  1. Add example.com to the "Always open in this container" list
  2. Open oauth-example.com in a window like this:
    window.open('https://oauth-example.com','authWindow', 
             'width=600,height=400,menubar=no,toolbar=no,status=no,scrollbars=no,resizable=no'
    );
  3. Have oauth-example.com redirect to example.com after it is done e.g. using
    window.location.href = "https://www.example.com";

(Real-World example, where i had the issue: If you include "https://admin.microsoft.com" in the list and then try adding an app there (Settings -> Integrated Apps), which requires you to consent to permissions)

Actual behavior

The Browser blocks the request, which is expected behaviour, but:

  • The JS Code is unable to know that the redirect did not succeed
  • The User does not know the redirect did not succeed
  • The User cannot manually decide how the browser should handle the redirect

Expected behavior

The Browser should either redirect in the same tab or show an informational message to the user, similar to what happens if they use it in a regular tab

Additional informations

No response

Provide a copy of Troubleshooting Information page (optional)

No response

@timon-michel-scopevisio timon-michel-scopevisio added the bug Something is broken! label Jul 31, 2024
@amiii123malviya
Copy link

Hello,

Is this issue still active?
I would like to work on this.

Best Regards.

@timon-michel-scopevisio
Copy link
Author

@amiii123malviya I may not have understood the question, but i submitted it 3 hours ago, which means it is still active, yes

@amiii123malviya
Copy link

@timon-michel-scopevisio i will look at this and will let you know soon.

Regards

@amiii123malviya
Copy link

Hello @timon-michel-scopevisio ,

I hope you are doing well,.
I just want you to know that i am working on this issue and soon i will let you know once i am done with this.

Best regards
Have a good day

@dannycolin dannycolin added the Component: Site Assignment Issues related to assigning a site to a container label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken! Component: Site Assignment Issues related to assigning a site to a container
Projects
None yet
Development

No branches or pull requests

3 participants