Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build test fails #246

Open
oceancolorcoder opened this issue Oct 1, 2024 · 5 comments
Open

Build test fails #246

oceancolorcoder opened this issue Oct 1, 2024 · 5 comments

Comments

@oceancolorcoder
Copy link
Contributor

Application testing on build (merge to master) fails for all 3 platforms, each for its own reason with error

QWidget: Must construct a QApplication before a QWidget

appearing for macos and ubuntu at differing fail points and windows showing

Eforrtl: error (200): program aborting due to control-BREAK event

@juanchossn
Copy link
Contributor

To confrm once cdsapi branch is merged into dev.

@oceancolorcoder
Copy link
Contributor Author

@doizuc I tested this today by merging the updated ECMWF API (tested successfully in dev) into master, but it still failed. Haven't had a chance to check logs.

@doizuc
Copy link
Contributor

doizuc commented Dec 18, 2024

It still freezes during the download of ECMWF, I will have a look at it on my fork asap. Extract of logs below.

  File "/Users/runner/work/HyperCP/HyperCP/Source/ProcessL1bTriOS.py", line 389, in processL1b
    modRoot = GetAnc_ecmwf.getAnc_ecmwf(ancGroup)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/work/HyperCP/HyperCP/Source/GetAnc_ecmwf.py", line 199, in getAnc_ecmwf
    ancillary = GetAnc_ecmwf.get_ancillary_main(lat[index], lon[index], lat_timeStamp, ancPath)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/runner/work/HyperCP/HyperCP/Source/GetAnc_ecmwf.py", line 154, in get_ancillary_main
    GetAnc_ecmwf.CAMS_download_ensembles(latEff, lonEff, dateTagEff, timeStampEff, CAMS_variables, pathOut)
  File "/Users/runner/work/HyperCP/HyperCP/Source/GetAnc_ecmwf.py", line 107, in CAMS_download_ensembles
    exit()
  File "<frozen _sitebuiltins>", line 26, in __call__
SystemExit: None

@oceancolorcoder
Copy link
Contributor Author

Also noticed that the last build was associated with older assets (deleted when draft updated):
image

@doizuc
Copy link
Contributor

doizuc commented Jan 8, 2025

The Build & Release Pipeline passes as noted during our meeting. The issue with assets in the draft release is because the draft release of the previous version wasn't published (looking at HyperCP release page there is no version v1.2.9). If that happens again, you should be able to delete the assets from the previous release while editing the release draft.

Concerning the Application Testing, it just failed again on the main repo, so I went ahead and synchronized my fork and ran the actions... it passed. I suspect there is an issue in the format of the repository secrets. The secrets should contain exactly what the .netrc and .ecmwf_ads_credential files contains. In fact, the action is writing directly the content of the secret to the file (see below extract of github action). Unfortunately, you can't see the content of the secret to edit it. Could you reset the secret variable ECMWF_ADS_CREDENTIALS following the instructions from PR #280 ? The variable NETRC seems fine.

NETRC: ${{ secrets.NETRC }}
echo "$NETRC" >> ~/.netrc

CDSAPIRC: ${{ secrets.ECMWF_ADS_CREDENTIALS }}
echo "$CDSAPIRC" >> ~/.ecmwf_ads_credentials.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants