Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Notary Service API to simplify multi-signature transaction signing #3770

Open
End-rey opened this issue Dec 19, 2024 · 0 comments
Open
Labels
enhancement Improving existing functionality I3 Minimal impact rpc RPC server and client S3 Minimally significant U4 Nothing urgent

Comments

@End-rey
Copy link

End-rey commented Dec 19, 2024

Is your feature request related to a problem? Please describe.

Currently, signing transactions in the notary service requires manual manipulation of invocation scripts. This includes removing existing invocation script from the transaction that was received from the notary pool, and ensuring the correct actor is used to match the transaction's original signers. This process is cumbersome, error-prone, and counterintuitive, especially when the goal is simply to append a signature to an existing transaction.

Describe the solution you'd like

Just use GetRawNotaryTransactionVerbose + Sign (or any other method that would make it easier to add a signature obtained from the notary pool) and everything works.

Describe alternatives you've considered

Current Manual Process:

  1. Retrieve the transaction using GetRawNotaryTransactionVerbose.
  2. Manually strip all existing invocation scripts.
  3. Use Sign with a properly configured actor.

This works but is not user-friendly and can lead to confusion or errors, as noted during debugging.

@End-rey End-rey added feature Completely new functionality I2 Regular impact labels Dec 19, 2024
@roman-khimov roman-khimov added I3 Minimal impact U4 Nothing urgent enhancement Improving existing functionality S3 Minimally significant rpc RPC server and client and removed feature Completely new functionality I2 Regular impact labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I3 Minimal impact rpc RPC server and client S3 Minimally significant U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

2 participants