Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing compatibility code from Neo's registerCandidate #3774

Open
AnnaShaleva opened this issue Dec 23, 2024 · 0 comments
Open

Consider removing compatibility code from Neo's registerCandidate #3774

AnnaShaleva opened this issue Dec 23, 2024 · 0 comments
Labels
blocked Can't be done because of something enhancement Improving existing functionality I4 No visible changes S4 Routine U4 Nothing urgent

Comments

@AnnaShaleva
Copy link
Member

AnnaShaleva commented Dec 23, 2024

Is your feature request related to a problem? Please describe.

#3700 introduces a workaround to native Neo's registerCandidate callback to ensure state processing compatibility before Echidna:

if !ic.IsHardforkEnabled(config.HFEchidna) {
ok, err := runtime.CheckKeyedWitness(ic, pub)
if err != nil {
panic(err)
} else if !ok {
return stackitem.NewBool(false)
}
}

See also neo-project/neo#3597 (comment).

This compatibility code may be dropped after transition to Echidna, but we need to check public networks for compatibility before this change.

Describe the solution you'd like

Drop the code, process N3 mainnet/testnet, ensure states are not affected by this change.

@AnnaShaleva AnnaShaleva added U4 Nothing urgent enhancement Improving existing functionality S4 Routine I4 No visible changes blocked Can't be done because of something labels Dec 23, 2024
@AnnaShaleva AnnaShaleva changed the title Consider removing compatibility code from Neo's onNEP17Payment Consider removing compatibility code from Neo's registerCandidate Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Can't be done because of something enhancement Improving existing functionality I4 No visible changes S4 Routine U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

1 participant