[AndroidTV] PhilipsTV power channel change values after thing thing got offline

[NikolayKash]

Expected Behavior

Keep value as OFF, instead setting it ON and immediately set it to OFF after thing got online

Current Behavior

Item value is OFF
Thing got OFFINE
Thing get ONLINE
Item value set to ON
Almost the same time it gets OFF.

PSA screenshot

Possible Solution

keep OFF value instead of ON

Steps to Reproduce (for Bugs)

Item value is OFF
Thing got OFFINE
Thing get ONLINE
Item value set to ON
Almost the same time it gets OFF.

Context

I have a PhilipsTV and use this configuration

As I persist state of TV there are lots of ON OFF entries generated during a day while TV was off full day.

Could it be related to this logic?

openhab-addons/bundles/org.openhab.binding.androidtv/src/main/java/org/openhab/binding/androidtv/internal/protocol/philipstv/service/PowerService.java

Line 69 in 4dfaef9

handler.checkPendingPowerOn();

Debug log around the issue:

Your Environment

runtimeInfo:
  version: 4.3.2
  buildString: Release Build
systemInfo:
  javaVersion: 17.0.13
  javaVendor: Ubuntu
  osName: Linux
  osVersion: 6.8.0-51-generic

addons:
  - binding-androidtv
  
clientInfo:
  device:
    desktop: true
    language: en-US
    languages:
      - en-US
    onLine: true
    platform: Linux x86_64

[openhab-bot]

This issue has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/androidtv-binding-3-2-0-4-2-0/142203/562

[morph166955]

EDIT: I found the offending code.

openhab-addons/bundles/org.openhab.binding.androidtv/src/main/java/org/openhab/binding/androidtv/internal/protocol/philipstv/PhilipsTVConnectionManager.java

Line 537 in 4dfaef9

handler.updateChannelState(CHANNEL_POWER, OnOffType.ON);

When the thing state is set to online (and not in standby) it auto sets the power to ON. We probably should be calling for it to refresh instead.

[NikolayKash]

Hi @morph166955 it looks so. If you can create a fix and publish a bundle, I can test it.

[morph166955]

Working on that right now. Just moved to a new dev box and I'm having issues with Maven. Once I get that resolved I should be able to build a test jar. Might be a few days, not sure why it's breaking currently.