Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac grep not supported #14

Open
swtch1 opened this issue Jul 18, 2022 · 1 comment
Open

mac grep not supported #14

swtch1 opened this issue Jul 18, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@swtch1
Copy link

swtch1 commented Jul 18, 2022

What did you do?

$ ./deploy-infra.sh

What did you expect to happen?

For infra components to be deployed successfully.

What actually happened?

grep: invalid option -- P
usage: grep [-abcdDEFGHhIiJLlMmnOopqRSsUVvwXxZz] [-A num] [-B num] [-C[num]]
        [-e pattern] [-f file] [--binary-files=value] [--color=when]
        [--context[=num]] [--directories=action] [--label] [--line-buffered]
        [--null] [pattern] [file ...]
grep: invalid option -- P
usage: grep [-abcdDEFGHhIiJLlMmnOopqRSsUVvwXxZz] [-A num] [-B num] [-C[num]]
        [-e pattern] [-f file] [--binary-files=value] [--color=when]
        [--context[=num]] [--directories=action] [--label] [--line-buffered]
        [--null] [pattern] [file ...]
Server version:
Agent version:
error: unable to read URL "https://github.com/parca-dev/parca/releases/download//kubernetes-manifest.yaml", server reported 404 Not Found, status code=404
error: unable to read URL "https://github.com/parca-dev/parca-agent/releases/download//kubernetes-manifest.yaml", server reported 404 Not Found, status code=404
Connect to Parca by running: kubectl port-forward -n parca svc/parca 7070
go install -v github.com/jsonnet-bundler/jsonnet-bundler/cmd/jb@latest
...

The script tries to use grep -P which is not supported on my Mac, and continues despite the error.

Software Versions

$ bash --version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin21)
Copyright (C) 2007 Free Software Foundation, Inc.
@kakkoyun kakkoyun added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Jul 19, 2022
@kakkoyun
Copy link
Member

Oops, we weren't inclusive enough to MacOS users with our commands. We'll check it out. Better to use vars in the Makefile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants