-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mp3 Seeking has warnings in logs #274
Comments
Update: i have now read over the documentation again for seeking, it says that the decoder should be reset after seeking, which actually helped for mp3, though it seems to not be required for other decoders.
Another Update: |
…mp3) as recommended by symphonia. fixes audible "noise" while playing mp3 re pdeljanov/Symphonia#274
…mp3) as recommended by symphonia. fixes audible "noise" while playing mp3 re pdeljanov/Symphonia#274
I have noticed that when playing mp3's and then seek, the following warnings / messages come up in the logs, while also in the audio output being noticeable "noise":
This seems to only happen on mp3's, not on mka(vorbis) or m4a(aac), with the same (transpiled) track; this also happens on any other mp3 i try.
This happens in both
SeekMode::Coarse
andSeekMode::Accurate
.I could not reproduce this on
symphonia-play
as that does not have live seek (only initial seek).symphonia 0.5.4
rustc 1.77.1
linux (playback via cpal alsa into pipewire)
For context, some code:
how the seek is done
and the decode loop
Note: even when adding a
required_ts
check like insymphonia-play
, it does not change the warnings or outputted "noise"Note: i used "noise" as i dont quite know how else to describe it other than a mix of "popping" and "squeaking"
sample with 5 seeks done at somewhat regular intervals sample.tar.gz (length: 2 seconds)
The text was updated successfully, but these errors were encountered: